maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MRRESOURCES-94) Performance issue in ProcessRemoteResourcesMojo.configureVelocityContext(...)
Date Thu, 13 Jul 2017 09:23:00 GMT

    [ https://issues.apache.org/jira/browse/MRRESOURCES-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085427#comment-16085427
] 

ASF GitHub Bot commented on MRRESOURCES-94:
-------------------------------------------

GitHub user famod opened a pull request:

    https://github.com/apache/maven-plugins/pull/123

    MRRESOURCES-94 Introduce excludeDependencyProjects parameter

    This parameter can be enabled to avoid the possibly excessive overhead of the dependency
projects lookup for the projects* velocity properties.
    
    This does _not_ solve the root cause of MRRESOURCES-94 (which I'd call "problem by design")
but it provides a reasonable workaround for users that don't need the `projects*` properties.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/famod/maven-plugins MRRESOURCES-94

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-plugins/pull/123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #123
    
----
commit 5f603675acc931a43c57eae3ba4a251c1bb89947
Author: Falko Modler <falko.modler@t-systems.com>
Date:   2017-07-13T09:14:52Z

    MRRESOURCES-94 Introduce excludeDependencyProjects parameter
    
    This parameter can be enabled to avoid the possibly excessive overhead of
    the dependency projects lookup for the projects* velocity properties.

----


> Performance issue in ProcessRemoteResourcesMojo.configureVelocityContext(...)
> -----------------------------------------------------------------------------
>
>                 Key: MRRESOURCES-94
>                 URL: https://issues.apache.org/jira/browse/MRRESOURCES-94
>             Project: Maven Remote Resources Plugin
>          Issue Type: Bug
>    Affects Versions: 1.5
>            Reporter: Falko Modler
>
> I was wondering why our multi-threaded maven build of 80+ modules took so long even when
excluding tests. I checked every plugin execution and to my surprise, {{maven-remote-resources-plugin}}
was the number 1 consumer *before* compiler-plugin etc.
> We use {{maven-remote-resources-plugin}} just to exchange some few xml files among the
modules, nothing spectacular!
> While debugging the plugin I found out that {{ProcessRemoteResourcesMojo.configureVelocityContext(VelocityContext
context)}} may take *up to 30 seconds* for our project setup which is not acceptable.
> Almost certainly the problem is caused by the following project lookups (especially {{getProjects()}}):
> {noformat}
>         List<MavenProject> projects = getProjects();
>         context.put( "projects", projects );
>         context.put( "projectsSortedByOrganization", getProjectsSortedByOrganization(
projects ) );
> {noformat}
> As we do not use velocity templates at all, the solution for us was to patch the plugin
to call {{configureVelocityContext(...)}} only on demand, not eagerly. Of course this won't
help when using velocity templates...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message