maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Scholte (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MJAR-138) jar:test-jar is skipped when maven.test.skip=true
Date Sun, 10 Sep 2017 16:27:00 GMT

    [ https://issues.apache.org/jira/browse/MJAR-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160395#comment-16160395
] 

Robert Scholte commented on MJAR-138:
-------------------------------------

There are a couple of plugin "listening" to this property:
* [compiler:testCompile skip|https://maven.apache.org/plugins/maven-compiler-plugin/testCompile-mojo.html#skip]
* [surefire:test skip|https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#skip]
* [jar:test-jar skip|https://maven.apache.org/plugins/maven-jar-plugin/test-jar-mojo.html#skip]

I don't know the complete history of this property, but I can imagine the following: if you
don't want to run tests, no need to compile them nor to package them. It is not such a weird
idea to have the property cause this as default behavior, but is it correct?

> jar:test-jar is skipped when maven.test.skip=true
> -------------------------------------------------
>
>                 Key: MJAR-138
>                 URL: https://issues.apache.org/jira/browse/MJAR-138
>             Project: Maven JAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.3.1
>         Environment: jar:test-jar
>            Reporter: Andrew Hughes
>             Fix For: more-investigation
>
>         Attachments: MJAR-138-maven-jar-plugin.patch
>
>
> Not sure if this is a bug or improvement...
> Example:
> * ./pom.xml
> * ./moduleA/pom.xml
> * ./moduleB/pom.xml
> Situation:
> * moduleA produces moduleA-1.2.3-test.jar with the jar:test-jar goal
> * moduleB consumes moduleA-1.2.3-test.jar as a <dependency>...<scope>test</scope><dependency>
> Problem:
> * When -Dmaven.test.skip=true the moduleA-1.2.3-test.jar is never built.
> * Then when moduleB tries to build, it's moduleA-1.2.3-test.jar dependency is unresolved.
FAIL! Even with -Dmaven.test.skip=true this will fail.
> You might argue that this is a bug with dependency resolution with -Dmaven.test.skip=true
- should a missing dependency @ test scope really fail the build??? It probably should - which
is why the bug is submitted here :)
> I've no idea what could be done to fix this either?
> ---
> p.s. for anyone with this bug the only workaround I can suggest is running another module...
> ./moduleA-test/pom.xml
> and have <dependency>...<artifactId>moduleA-test<artifactId>...<scope>test</scope></dependency>



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message