maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MNG-5600) Dependency management import should support exclusions.
Date Mon, 02 Oct 2017 11:30:01 GMT

    [ https://issues.apache.org/jira/browse/MNG-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187884#comment-16187884
] 

ASF GitHub Bot commented on MNG-5600:
-------------------------------------

GitHub user jtnord opened a pull request:

    https://github.com/apache/maven/pull/133

    [MNG-5600] Dependency management import should support exclusions.

    https://github.com/ChristianSchulte/maven/commit/679a34b86e3d69b7a832481c7f21e5eab367cd11
cherry picked into master

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jtnord/maven MNG-5600

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #133
    
----
commit 4130977e349c6abed929e463473cbd703f13f047
Author: Christian Schulte <schulte@apache.org>
Date:   2016-06-19T14:32:25Z

    [MNG-5600] Dependency management import should support exclusions.

----


> Dependency management import should support exclusions.
> -------------------------------------------------------
>
>                 Key: MNG-5600
>                 URL: https://issues.apache.org/jira/browse/MNG-5600
>             Project: Maven
>          Issue Type: Improvement
>          Components: Dependencies
>            Reporter: Radai Rosenblatt
>             Fix For: 3.5.x-candidate
>
>
> suppose i have a multi-module project that uses spring, and so have this in dependency-managements
in a parent pom:
> {code:xml}
> <dependency>
> 	<groupId>org.springframework</groupId>
> 	<artifactId>spring-framework-bom</artifactId>
> 	<version>${org.springframework.version}</version>
> 	<type>pom</type>
> 	<scope>import</scope>	
> </dependency>
> {code}
> spring artifacts (or at least a lot of them) have a dependency on commons-logging. right
now, if i want to exclude commons-logging i have to add an exclusion to every spring dependency
in every module of my project, which is actually more XML overall than giving up on using
the bom dependency altogether and listing all spring dependencies with excludes once in the
parent dependency management.
> I'd like to be able to do this:
> {code:xml}
> <dependency>
> 	<groupId>org.springframework</groupId>
> 	<artifactId>spring-framework-bom</artifactId>
> 	<version>${org.springframework.version}</version>
> 	<type>pom</type>
> 	<scope>import</scope>
> 	<exclusions>
> 		<exclusion>
> 			<artifactId>commons-logging</artifactId>
> 			<groupId>commons-logging</groupId>
> 		</exclusion>
> 	</exclusions>
> </dependency>
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message