maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tibor Digana (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1226) Surefire trims all stack trace elements except those in the test that failed
Date Sun, 01 Oct 2017 11:20:02 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187344#comment-16187344
] 

Tibor Digana commented on SUREFIRE-1226:
----------------------------------------

[~jglick@netbeans.org]
[~jlocker@redhat.com]
[~Srdo]
Let me follow [~Srdo]'s example. Basically he wants to see the Kafka's class {{KafkaSpout}}
right before {{KafkaSpoutCommitTest}} in the stack trace. This is against the documentation
and against what trim means. The trim is set to {{true}} by default. The documentation did
not change since 2012 and it will not change. Unfortunately you stick to behavior of old version.
I understand that you develop Kafka and Jenkins Plugins and you want to see where the framework
crashed. I understand people who want to see only assertion error in test and not the stack
trace on {{JavaHamcrest}} nor {{AssertJ}}. These two are different requirements which cannot
be satisfied by {{boolean}} but unfortunately this boolean was here since 2012 and this is
your problen and not the behavior.
Please understand that with {{boolean}} and version 2.x I cannot change signature of this
parameter.
The only think in 2.x I can do is a fix or introduce a new feature but I cannot change {{boolean}}
to {{enum}} what you may maybe prefer more.
Therefore we have received many requests from Users to alter behavior of configuration parameters
or implement the parameters by users (inject functionality to plugin) and the only thing to
do it is to introduce alternatives in version 3.0. All parameters can have something like
this in 3.0:
{{<trimStackTrace implements="org.apache.maven.surefire.extensions.RetainTopStackTrace">true</trimStackTrace>}}
{{<trimStackTrace implements="org.apache.maven.surefire.extensions.RetainTopCausesStackTrace">true</trimStackTrace>}}
{{<trimStackTrace implements="org.apache.maven.surefire.extensions.DefaultStackTrace">true</trimStackTrace>}}
{{<trimStackTrace implements="org.apache.maven.surefire.extensions.SmartStackTrace">true</trimStackTrace>}}
{{<trimStackTrace>false</trimStackTrace>}}

We can talk about the above implementations now and alternatives.

> Surefire trims all stack trace elements except those in the test that failed
> ----------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1226
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1226
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.19
>            Reporter: Jiri Locker
>            Assignee: Tibor Digana
>            Priority: Minor
>         Attachments: mvn_stacktrace.tar.gz
>
>
> This looks like a re-occurrence of SUREFIRE-992 but now the stack trace is even more
trimmed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message