maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MENFORCER-276) Allow ignoring dependency scopes in RequireUpperBoundDeps
Date Sat, 04 Nov 2017 14:44:00 GMT

    [ https://issues.apache.org/jira/browse/MENFORCER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239043#comment-16239043
] 

ASF GitHub Bot commented on MENFORCER-276:
------------------------------------------

oleg-nenashev opened a new pull request #25: MENFORCER-276 - Support ignoring dependency scopes
in RequireUpperBoundDeps
URL: https://github.com/apache/maven-enforcer/pull/25
 
 
   We have recently adopted `RequireUpperBoundDeps` in the Jenkins project (https://github.com/jenkinsci/plugin-pom/pull/67).
In order to implement it, Jesse Glick added a support of ignoring particular dependencies
in [MENFORCER-273](https://issues.apache.org/jira/browse/MENFORCER-273).
   
   Sometimes we declare dependencies between plugins for testing purposes (scope=test), and
in such case RequireUpperBoundDeps fails the build if there is a test dependency conflicting
with the main code. Although it may cause instability of tests (including false positive results),
it does not really impact the distributable package in our case.
   
   I propose to add another option for filtering of dependency scopes. This pull request also
adds some unit tests for `RequireUpperBoundDeps`. Previously it had integration tests only.
   
   https://issues.apache.org/jira/browse/MENFORCER-276
   
   @reviewbybees @jglick @stephenc 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow ignoring dependency scopes in RequireUpperBoundDeps
> ---------------------------------------------------------
>
>                 Key: MENFORCER-276
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-276
>             Project: Maven Enforcer Plugin
>          Issue Type: New Feature
>            Reporter: Oleg Nenashev
>            Priority: Major
>
> We have recently adopted RequireUpperBoundDeps in the Jenkins project (https://github.com/jenkinsci/plugin-pom/pull/67).
In order to implement it, [~jglick@netbeans.org] added a support of ignoring particular dependencies
in MENFORCER-273.
> Sometimes we declare dependencies between plugins for testing purposes (scope=test),
and in such case RequireUpperBoundDeps fails the build if there is a test dependency conflicting
with the main code. Although it may cause instability of tests (including false positive results),
it does not really impact the distributable package in our case.
> I propose to add another option for filtering of dependency scopes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message