maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rfscholte commented on a change in pull request #1: [MSHARED-674] Detect Java 8 type annotations
Date Thu, 01 Jan 1970 00:00:00 GMT
rfscholte commented on a change in pull request #1: [MSHARED-674] Detect Java 8 type annotations
URL: https://github.com/apache/maven-dependency-analyzer/pull/1#discussion_r159634365
 
 

 ##########
 File path: src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzerTest.java
 ##########
 @@ -302,17 +303,44 @@ public void testMultimoduleProject()
         assertEquals( expectedAnalysis, actualAnalysis );
     }
 
+    public void testTypeUseAnnotationDependency()
+            throws TestToolsException, ProjectDependencyAnalyzerException
+    {
+        // java.lang.annotation.ElementType.TYPE_USE introduced with Java 1.8
+        Assume.assumeTrue(SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_1_8));
 
 Review comment:
   Assumptions doesn't work with methodName based tests like PlexusTestCase still does.
   See https://builds.apache.org/job/maven-box/job/maven-dependency-analyzer/job/MSHARED-674_Detect_Java_8_type_annotations/1/
   
   For know I'd suggest to simple do a return when this value is false, but keep the code
once PlexusTestCase is upgraded.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message