maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ilya Basin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SCM-869) gitexe list() implemented incorrectly
Date Wed, 11 Apr 2018 12:01:00 GMT

    [ https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433793#comment-16433793
] 

Ilya Basin commented on SCM-869:
--------------------------------

I've updated the pull request to completely unimplement the list() method. Now the default
implementation in AbstractScmProvider will throw NoSuchCommandScmException

> gitexe list() implemented incorrectly
> -------------------------------------
>
>                 Key: SCM-869
>                 URL: https://issues.apache.org/jira/browse/SCM-869
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-gitexe
>    Affects Versions: 1.9.5, 1.9.6
>            Reporter: Ilya Basin
>            Priority: Major
>
> Taking the Svn implementation as a model, ScmProvider.list() should be implemented as
follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote repository
must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The recommended value
is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command should just
fail.
> For listing files in a working copy, users should call the ScmProvider.status() method
instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message