maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ilya Basin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SCM-882) ScmWagon has no way to work with GIT in binary mode
Date Sat, 21 Apr 2018 12:03:00 GMT

    [ https://issues.apache.org/jira/browse/SCM-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446765#comment-16446765
] 

Ilya Basin commented on SCM-882:
--------------------------------

Your .gitattributes file has nothing to do with the wagon test, because the test neither clones,
nor commits to the "maven-wagon" git repository. It clones the test git repository which is
similar to your {{test-repo-svn}} and is added by one of my other pull requests, see WAGON-501
.

Now, about the test resource. It is actually just one text file named "test-resource". Here's
a highlight of how it gets into the test repo:

// https://github.com/apache/maven-wagon/blob/be94400731575f54ff537ec90359460f42a561cc/wagon-provider-test/src/main/java/org/apache/maven/wagon/WagonTestCase.java#L150
resource = "test-resource";

// https://github.com/apache/maven-wagon/blob/be94400731575f54ff537ec90359460f42a561cc/wagon-provider-test/src/main/java/org/apache/maven/wagon/WagonTestCase.java#L927
putFile( resource, "test-resource", content );

// https://github.com/apache/maven-wagon/blob/be94400731575f54ff537ec90359460f42a561cc/wagon-provider-test/src/main/java/org/apache/maven/wagon/WagonTestCase.java#L879
wagon.put( sourceFile, resourceName );

> ScmWagon has no way to work with GIT in binary mode
> ---------------------------------------------------
>
>                 Key: SCM-882
>                 URL: https://issues.apache.org/jira/browse/SCM-882
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-cvs
>    Affects Versions: 1.9.5
>            Reporter: Ilya Basin
>            Assignee: Olivier Lamy (*$^¨%`£)
>            Priority: Major
>             Fix For: 1.9.6
>
>
> Msysgit will checkout wagon-scm test-resource with CRLF by default, breaking the test.
Need to clone with core.autocrlf=false



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message