maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SCM-714) mvn release:prepare fails if the command line is too long on windows
Date Fri, 04 May 2018 22:00:00 GMT

    [ https://issues.apache.org/jira/browse/SCM-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464439#comment-16464439
] 

ASF GitHub Bot commented on SCM-714:
------------------------------------

michael-o commented on a change in pull request #30: Fix for SCM-714: mvn release:prepare
fails if the command line is too long on windows
URL: https://github.com/apache/maven-scm/pull/30#discussion_r186231262
 
 

 ##########
 File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java
 ##########
 @@ -144,8 +165,11 @@ protected CheckInScmResult executeCheckInCommand( ScmProviderRepository
repo, Sc
             {
                 return new CheckInScmResult( null, statusConsumer.getChangedFiles() );
             }
-
-            Commandline clCommit = createCommitCommandLine( repository, fileSet, messageFile
);
+            
+            //SCM-714: Workaround for the Windows terminal command limit
+            //
+            Commandline clCommit = createCommitCommandLine( repository, new ScmFileSet( fileSet.getBasedir()
),
 
 Review comment:
   What is the purpose of this change? This affects `-a` to be added, but we did already add
untracked changes...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> mvn release:prepare fails if the command line is too long on windows
> --------------------------------------------------------------------
>
>                 Key: SCM-714
>                 URL: https://issues.apache.org/jira/browse/SCM-714
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-gitexe
>    Affects Versions: 1.8.1
>            Reporter: Felix Simmendinger
>            Assignee: Robert Scholte
>            Priority: Blocker
>
> The issue from SCM-697 does not solve the issue as the gitprovider is not using the add
command but the checkin command during a release.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message