maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MNG-4777) Match property for profile activation against a regex
Date Tue, 27 Nov 2018 19:30:03 GMT

    [ https://issues.apache.org/jira/browse/MNG-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700901#comment-16700901
] 

ASF GitHub Bot commented on MNG-4777:
-------------------------------------

rfscholte commented on issue #80: [MNG-4777] Match property for profile activation against
a regex
URL: https://github.com/apache/maven/pull/80#issuecomment-442186378
 
 
   Not anymore possible to merge. Also, changing the specification will have a negative effect
on all consumers of the pom. Allowing regex as property comes with extra requirements and
such profile must be removed when distributing the pom. 
   I'll close this PR, MNG-4777is still open.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Match property for profile activation against a regex
> -----------------------------------------------------
>
>                 Key: MNG-4777
>                 URL: https://issues.apache.org/jira/browse/MNG-4777
>             Project: Maven
>          Issue Type: Improvement
>          Components: Profiles
>    Affects Versions: 2.0.11
>            Reporter: Andreas Ebbert-Karroum
>            Priority: Major
>         Attachments: regex-project-property-profile-activator.patch
>
>
> For activating a profile it would be nice, in addition or as a seperate feature to MNG-3328,
to match a property not against a specific value but against a regex. In our case, we need
to set some properties for some hudson builds. Not only is that setup fragile against job
name changes, but also doesn't scale for multiple jobs. IMHO adding a regex matcher would
be a nice feature for multiple purposes.
> Old:
> {code:xml}
> <activation>
>   <property>
>     <name>env.JOB_NAME</name>
>     <value>xyz-abc-foo/label=robotframework,maven.browser-profile=firefox,maven.env-profile=dev</value>
>   </property>
> </activation>
> {code}
> New:
> {code:xml}
> <activation>
>   <property>
>     <name>env.JOB_NAME</name>
>     <regex>xyz-abc-foo/.*</regex>
>   </property>
> </activation>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message