maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MDEP-568) dependency:go-offline -DexcludeGroupIds=xxxx still try to resolve artifacts in the excluded group xxxx
Date Mon, 26 Nov 2018 09:44:00 GMT

    [ https://issues.apache.org/jira/browse/MDEP-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698685#comment-16698685
] 

ASF GitHub Bot commented on MDEP-568:
-------------------------------------

Theoderich commented on issue #2: MDEP-568 respect excludeGroupIds in go-offline
URL: https://github.com/apache/maven-dependency-plugin/pull/2#issuecomment-441576905
 
 
   Original Author of the patch here.
   
   As @cosmin has said, this feature is needed to build a clean maven repository with all
transitive dependencies of a project. In container based build engines like GitlabCI and CircleCi
you need to copy around the repository between build containers. You want the repository to
be as complete as possible so build steps don't need to download dependencies again and again,
but also as small as possible so you don't need to move around to much data.
   
   dependency:go-offline seemed to be the right tool. But it always tried to download the
inter-project dependencies of my multi-module project that
   a) Are not published anywhere, so the plugin fails
   b) I wouldn't want to have in my clean repository anyway
   
   With the changes of this patch, I was able to exclude the groupId if my project and get
the required results.
   
   So to answer your questions:
   - did it ever work?
   Not sure if it worked in any previous versions of the dependency plugin. The documentation
at least suggests that it should work.
   
   - does the patch fix both dependencies and plugins/reports?
   Dependencies already work in the master version since they are not collected automatically
via the requiresDependencyCollection annotation. Not sure about reports though.
   
   - for my understanding, what's the typical use case for excluding something, please?
   As described: Container based build platforms
   
   In the meanttime, I have also published a plugin especially designed for downloading dependencies
for build containers: https://github.com/qaware/go-offline-maven-plugin . It covers more edge
cases than the patch proposed here, since it is a complete re-write.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> dependency:go-offline -DexcludeGroupIds=xxxx still try to resolve artifacts in the excluded
group xxxx
> ------------------------------------------------------------------------------------------------------
>
>                 Key: MDEP-568
>                 URL: https://issues.apache.org/jira/browse/MDEP-568
>             Project: Maven Dependency Plugin
>          Issue Type: Bug
>          Components: go-offline, resolve
>    Affects Versions: 2.3, 3.0.0
>         Environment: windows / cygwin xp64 bit / bash / maven 3.0.3
>            Reporter: Archimedes Trajano
>            Priority: Major
>         Attachments: MDEP-568-maven-dependency-plugin.patch, go-offline_copy-dependencies_patch_sample.zip,
test.tgz
>
>
> see thread: http://mail-archives.apache.org/mod_mbox/maven-users/201109.mbox/%3c0B02C46601D44673A4A2DF4C4F907E9E@black%3e
> in attached sample pom structure:
> mvn org.apache.maven.plugins:maven-dependency-plugin:2.3:go-offline -DexcludeGroupIds=us.pdinc.foo.maven.test
> fails



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message