maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MNG-6261) Relative parent POM resolution failing in 3.5.0 with complex multimodule builds
Date Wed, 28 Nov 2018 01:25:00 GMT

    [ https://issues.apache.org/jira/browse/MNG-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701256#comment-16701256
] 

ASF GitHub Bot commented on MNG-6261:
-------------------------------------

slachiewicz commented on issue #192: [MNG-6261] - using java File api to compare
URL: https://github.com/apache/maven/pull/192#issuecomment-442282452
 
 
   +1
   
   And one more small testcase - should pass before/after patch
   `org.apache.maven.model.building.FileModelSource#getRelatedSource` - one use of normalize
   
   ```
      @Test
       public void testDiffrentPaths () throws IOException {
           Path tempDirParent = Files.createTempDirectory( "FileModelSource-" );
           Path subdir = Files.createDirectory( tempDirParent.resolve( "test" ) );
           Path pomFile = Files.createTempFile(subdir, "myCustomPom-", ".xml" );
   
           Path relativeFile = subdir.resolve( "../test/" + pomFile.getFileName() );
   
           assertNotEquals( pomFile, relativeFile );
           assertEquals( pomFile.normalize(), relativeFile.normalize());
   
           assertNotEquals( pomFile.toFile(), relativeFile.toFile() );
           assertNotEquals( pomFile.toFile().toURI(), relativeFile.toFile().toURI() );
   
           assertEquals( pomFile.toFile().getCanonicalFile(), relativeFile.toFile().getCanonicalFile()
);
           assertEquals( pomFile.toFile().toURI().normalize(), relativeFile.toFile().toURI().normalize()
);
   
           FileModelSource instance = new FileModelSource( pomFile.toFile() );
   
           assertNotEquals(instance, new FileModelSource( relativeFile.toFile() ) );
       }
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Relative parent POM resolution failing in 3.5.0 with complex multimodule builds
> -------------------------------------------------------------------------------
>
>                 Key: MNG-6261
>                 URL: https://issues.apache.org/jira/browse/MNG-6261
>             Project: Maven
>          Issue Type: Bug
>    Affects Versions: 3.5.0
>            Reporter: Dawid Weiss
>            Priority: Minor
>              Labels: up-for-grabs
>             Fix For: 3.6.x-candidate
>
>         Attachments: capture-6.png, repro.zip
>
>
> In my effort to upgrade an existing (fairly complex) Maven build to Java 1.9.0 I updated
Maven to 3.5.0 (from 3.3.9). Unfortunately I get errors when the project's modules are resolved:
> {noformat}
> > mvn validate
> [FATAL] Non-resolvable parent POM for com.carrotsearch.lingo4g:lingo4g-public-bom:[unknown-version]:
Could not find artifact com.carrotsearch.lingo4g:lingo4g-public:pom:1.6.0-SNAPSHOT and 'parent.relativePath'
points at wrong local POM @ line 5, column 11
> ...
> (and many follow).
> {noformat}
> This build has a correct pom parent-structure (a tree), but is fairly complex -- the
submodule hierarchy is not aligned with parent-child pom hierarchy (it's best to look at the
repro code to understand how it's structured).
> However, it's been working correctly with all prior Maven versions and I wonder if it's
a regression bug or maybe underspecified Maven requirement (that should be enforced with a
warning and not lead to this odd runtime message).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message