maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1588) Surefire manifest jar classloading broken on latest Debian/Ubuntu Java8
Date Fri, 02 Nov 2018 12:35:00 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673034#comment-16673034
] 

ASF GitHub Bot commented on SUREFIRE-1588:
------------------------------------------

Tibor17 commented on a change in pull request #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#discussion_r230358750
 
 

 ##########
 File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
 ##########
 @@ -114,7 +115,7 @@ private File createJar( @Nonnull List<String> classPath, @Nonnull
String startCl
             {
                 File file1 = new File( it.next() );
 
-                String uri = parent.relativize( file1.toPath() ).toString();
+                String uri = URI.create( parent.relativize( file1.toPath() ).toString() ).toASCIIString();
 
 Review comment:
   Works for me but the annoying are logs because we log every Jar file.
   This can be fixed by using a boolean flag preventing from repeative logs with same message.
   Can you segregate the try-catch to a private method?
   I have a question regarding the bug. The build plugin crashed with plugin version `2.22.1`
on 1.8.0_192? It did not crash on my Windows system. It is different experience on Linux?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Surefire manifest jar classloading broken on latest Debian/Ubuntu Java8
> -----------------------------------------------------------------------
>
>                 Key: SUREFIRE-1588
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1588
>             Project: Maven Surefire
>          Issue Type: Bug
>    Affects Versions: 2.22.1
>            Reporter: Cservenak, Tamas
>            Priority: Major
>
> See issue [1], but in short: latest Java8 on Ubuntu/Debian/Mint family of Linuxes (am
on Mint, Ubuntu derivative) contains this patch [3], and eforces Manifest class path entries
to be relative, as defined in [2].
> Hence, surefire booter and rest of Maven classpath, that uses absolute URLs are simply
discarded.
> Example error:
> {noformat}
> # Created at 2018-10-30T21:34:43.339
> Error: Could not find or load main class org.apache.maven.surefire.booter.ForkedBooter{noformat}
> using the new property {{-Djdk.net.URLClassPath.disableClassPathURLCheck=debug}} clearly
shows that all the entries from the surefire JAR are simply ignored.
>  
> [1] [https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911925]
> [2] https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jar.html#classpath
> [3] [https://hg.openjdk.java.net/jdk/jdk/rev/27135de165ac]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message