maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MJAR-260) Upgrade to Archiver 3.3.0 and add ITs
Date Sat, 24 Nov 2018 22:45:00 GMT

    [ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697998#comment-16697998
] 

ASF GitHub Bot commented on MJAR-260:
-------------------------------------

sormuras commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module
name
URL: https://github.com/apache/maven-jar-plugin/pull/3#discussion_r236055522
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
 ##########
 @@ -223,6 +226,18 @@ public File createArchive()
 
             archiver.createArchive( session, project, archive );
 
+            JarFile javaUtilJarFile = new JarFile( jarFile );
 
 Review comment:
   Maven Archiver 3.3.0 was just published and performs the check described above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Upgrade to Archiver 3.3.0 and add ITs
> -------------------------------------
>
>                 Key: MJAR-260
>                 URL: https://issues.apache.org/jira/browse/MJAR-260
>             Project: Maven JAR Plugin
>          Issue Type: Improvement
>            Reporter: Christian Stein
>            Assignee: Christian Stein
>            Priority: Minor
>             Fix For: 3.1.1
>
>
> The Maven Archiver version `3.3.0` fails to create a JAR file when an invalid automatic
module name is detected within the `META-INF/MANIFEST.MF` file. The Archiver throws an Exception
instead.
> For details seeĀ [https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message