maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MNG-6529) ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
Date Tue, 27 Nov 2018 14:59:00 GMT

    [ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700541#comment-16700541
] 

ASF GitHub Bot commented on MNG-6529:
-------------------------------------

mickaelistria opened a new pull request #193: MNG-6529 - JUnit Test showcasing the bug
URL: https://github.com/apache/maven/pull/193
 
 
   This adds a (failing) unit test showcasing that
   ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest)
   doesn't honor ProjectBuildingRequest.isResolveDependencies()
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed

          for the change (usually before you start working on it).  Trivial changes like typos
do not 
          require a JIRA issue.  Your pull request should address just this issue, without

          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of
the 
          commit message.
    - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will

          be performed on your pull request automatically.
    - [x] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if
you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version
2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't
honor ProjectBuildingRequest.isResolveDependencies()
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MNG-6529
>                 URL: https://issues.apache.org/jira/browse/MNG-6529
>             Project: Maven
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.5.3
>            Reporter: Mickael Istria
>            Priority: Critical
>
> I'm willing to upfate Eclipse m2e to take advantage of the `ProjectBuilder.build(List<File>
project, boolean, ProjectBuildingRequest)` in Eclipse m2e to avoid duplication of MavenProject
in the IDE in place of `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's
already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20]
and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
> However, using this cause regressions because the multi-projects entry-point method seems
to totally ignore the `ProjectBuildRequest.isResolveDependencies()` flag and never returns
a valid list of `MavenProject.getArtifacts()`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message