maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] eolivelli commented on a change in pull request #204: [SUREFIRE-1602] Surefire fails loading class ForkedBooter when using a sub-directory pom file and a local maven repo
Date Sun, 02 Dec 2018 11:25:46 GMT
eolivelli commented on a change in pull request #204: [SUREFIRE-1602] Surefire fails loading
class ForkedBooter when using a sub-directory pom file and a local maven repo
URL: https://github.com/apache/maven-surefire/pull/204#discussion_r238094508
 
 

 ##########
 File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
 ##########
 @@ -103,7 +103,7 @@ private File createJar( @Nonnull List<String> classPath, @Nonnull
String startCl
         {
             file.deleteOnExit();
         }
-        Path parent = file.getParentFile().toPath();
+        Path parent = file.getParentFile().toPath().normalize();
 
 Review comment:
   That project is huge, it downloads a lot of deps I mean.
   
   My problem with an it test is that the real problem arises only while using the combo:
local maven repository + using -file with a non canonical path for pom.
   
   So even if I import that project I don't know how to reproduce that set of parameters,
do you know how with current tests suites in surefire?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message