maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] khmarbaise commented on a change in pull request #47: Improve output
Date Mon, 10 Dec 2018 20:29:42 GMT
khmarbaise commented on a change in pull request #47: Improve output
URL: https://github.com/apache/maven-enforcer/pull/47#discussion_r240368459
 
 

 ##########
 File path: enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequirePluginVersions.java
 ##########
 @@ -278,8 +278,9 @@ public void execute( EnforcerRuleHelper helper )
                     {
                         newMsg.append( "SNAPSHOT " );
                     }
-                    newMsg.append( "are not allowed )\n" );
+                    newMsg.append( "are not allowed)" );
                 }
+                newMsg.append( "\n" );
                 for ( Plugin plugin : failures )
 
 Review comment:
   Shouldn't we use `System.lineSeparator()` instead of `\n` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message