maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Heinz Marbaise (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?
Date Tue, 11 Dec 2018 18:14:00 GMT

    [ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717684#comment-16717684
] 

Karl Heinz Marbaise commented on MENFORCER-324:
-----------------------------------------------

[~eolivelli] If I correctly understood you have create the branch MENFORCER-324 which contains
the following message:
{code}
~/ws-git-maven/enforcer (MENFORCER-324)$ git log -1 --format=full
commit 0afa4733310059f4ae75d7384b2df35a02ad52fc (HEAD -> MENFORCER-324, origin/MENFORCER-324)
Author: Josh Soref <jsoref@users.noreply.github.com>
Commit: Josh Soref <jsoref@users.noreply.github.com>

    [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
{code}
If you merge a PR you have to do a {{git commit --amend}} the given commit to have yourself
as a committer in the git log. This will approve a commit.
Something like this:
{code}
commit caef332f7598264ffc21d79bf9c4e6e4028a8210
Author: Alex Shesterov <alex.shesterov@gmail.com>
Commit: Karl Heinz Marbaise <khmarbaise@apache.org>

    [MENFORCER-320] - RequireProfileIdsExist check fails if no profiles have been specified
     - RequireProfileIdsExist check must not fail if there are no profiles
       in the pom.xml and no profiles have been specified in the command line
     - fix site: breadcrumbs on the "requireProfileIdsExist" page.
{code}
Otherwise it will look like a non committer has committed code into the code base..

> Shouldn't we use System.lineSeparator() instead of \n ?
> -------------------------------------------------------
>
>                 Key: MENFORCER-324
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-324
>             Project: Maven Enforcer Plugin
>          Issue Type: Bug
>            Reporter: Josh Soref
>            Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message