maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] britter commented on a change in pull request #217: Set properties readonly where it doesn't make sense to change values
Date Sun, 03 Feb 2019 09:30:19 GMT
britter commented on a change in pull request #217: Set properties readonly where it doesn't
make sense to change values
URL: https://github.com/apache/maven-surefire/pull/217#discussion_r253294200
 
 

 ##########
 File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
 ##########
 @@ -242,11 +242,12 @@
     private String[] additionalClasspathElements;
 
     /**
-     * The test source directory containing test class sources.
+     * The test source directory containing test class sources. Only used by the TestNG provider
to process JavaDoc
+     * tags.
      *
      * @since 2.2
      */
-    @Parameter( defaultValue = "${project.build.testSourceDirectory}", required = true )
+    @Parameter( defaultValue = "${project.build.testSourceDirectory}", readonly = true )
     private File testSourceDirectory;
 
 Review comment:
   The property is only used by the TestNG provider. Old TestNG versions needed this to process
custom JavaDoc tags. This was before Java had annotations. TestNG provided custom JavaDoc
test to mark your tests. For this reason TestNG needed the test sources and not only the compiled
test classes.
   
   To be honest, I would deprecate this property and mark it for removal for 3.0.0. I'm not
even sure the custom JavaDoc tags are supported by recent TestNG versions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message