maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] michael-o commented on a change in pull request #88: SCM-917 add untag for svn
Date Fri, 08 Feb 2019 23:58:52 GMT
michael-o commented on a change in pull request #88: SCM-917 add untag for svn
URL: https://github.com/apache/maven-scm/pull/88#discussion_r255270076
 
 

 ##########
 File path: maven-scm-api/src/main/java/org/apache/maven/scm/command/untag/AbstractUntagCommand.java
 ##########
 @@ -31,18 +31,27 @@
 public abstract class AbstractUntagCommand
     extends AbstractCommand
 {
+    /**
+     * SCM-917 - scm:untag for subversion
+     * @param repository scm repo
+     * @param fileSet set of files (unused)
+     * @param tagName tag name to remove
+     * @param message to use for commit comment
+     * @return result of untag command
+     * @throws ScmException  in case of error
+     */
     protected abstract ScmResult executeUntagCommand( ScmProviderRepository repository,
-        ScmFileSet fileSet, String tagName )
-        throws ScmException;
+        ScmFileSet fileSet, String tagName, String message ) throws ScmException;
 
     /** {@inheritDoc} */
+    @Override
     public ScmResult executeCommand( ScmProviderRepository repository, ScmFileSet fileSet,
-                                     CommandParameters parameters )
-        throws ScmException
+        CommandParameters parameters ) throws ScmException
     {
         String tagName = parameters.getString( CommandParameter.TAG_NAME );
+        String message = parameters.getString( CommandParameter.MESSAGE, "[maven-scm] untag
" + tagName );
 
 Review comment:
   The opposite says: "copy for tag". This should be similar: "remove tag".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message