maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Tibor17 commented on issue #221: [SUREFIRE-1638] Support running tests until failure or N test runs
Date Sat, 16 Feb 2019 03:35:08 GMT
Tibor17 commented on issue #221: [SUREFIRE-1638] Support running tests until failure or N test
runs
URL: https://github.com/apache/maven-surefire/pull/221#issuecomment-464280038
 
 
   @galderz 
   @olamy 
   The report was not designed for this loop and it will detect re-run feature. 
   The report class is called `stateless` but it is not stateless because the states (`HashMap`)
are entered via constructor which is necessary in re-run. I think the last run wins in this
feature. You should avoid both features running together by throwing exception in `AbstractSurefireMojo`.
   In SUREFIR-1222 we want to mark report statistics data with `normal run` or `rerun` and
then this HashMap and the algorithm should change and should not depend on order of runs.
Caching can be done before the reporter and the reporter can be called once which means the
class would be stateless again. In SUREFIRE-1638 we should do the same and mark the report
statistics data. Let's do it after SUREFIRE-1222 the runs of test in this feature which means
the re-run feature is avoided and the algorith will detect this feature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message