maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clemens Quoß (JIRA) <>
Subject [jira] [Commented] (SCM-917) Implement scm:untag for Subversion provider
Date Wed, 06 Feb 2019 07:41:00 GMT


Clemens Quoß commented on SCM-917:

Michael, I tried to push the SCM-917 branch for the pull request, but it seems I lack authority:

remote: Permission to apache/maven-scm.git denied to cquoss.

What is the proper way to hand in the pull request?

Some questions remain:
 * What use has the SCM Manager API?  It seems outdated.
 * How are the TckTest classes being run? Some of them (JGit for example) are running during
normal build.  I provided 'normal' and Tck svn untag tests, but I see only the normal tests.
 * Do you want me to provide an UntagMojo Test for Sobversion in the plugin tests?
 * Should I fix the checkstyle error in jgit?  Classes JGitCheckoutCommand, JGitTransportConfigCallbak,
JGitUtils and JGitRemoteInfoCommand produce > 100 checkstyle errors in sum.



> Implement scm:untag for Subversion provider
> -------------------------------------------
>                 Key: SCM-917
>                 URL:
>             Project: Maven SCM
>          Issue Type: Improvement
>          Components: maven-scm-provider-svn
>    Affects Versions: 1.11.1
>            Reporter: Clemens Quoß
>            Priority: Critical
>             Fix For: waiting-for-feedback
>         Attachments: git-diff-master.out, image-2019-02-02-16-57-33-664.png
> In order to work on MRELEASE-229, I would like to provide a PR for SCM to enable remote
removal for provider svn.
> Short outline:
> Introducing new parameter on scm:remove "remoteRemove" (alternative: use pushChanges
for this for svn, but this might be confusing).
> Implementation:
> New execute method in SvnRemoveCommand using a new ScmRemoveParameters carrying this
new parameter.  If true, use url from repository as base to construct targets from scm file
set in command line.
> [UPDATE] - Implementation of scm:untag command will now be the target of this issue
(follow comment discussion)

This message was sent by Atlassian JIRA

View raw message