maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-compiler-plugin] rhowe opened a new pull request #19: (doc) Simplify CompilationFailureException
Date Tue, 21 May 2019 07:26:26 GMT
rhowe opened a new pull request #19: (doc) Simplify CompilationFailureException
URL: https://github.com/apache/maven-compiler-plugin/pull/19
 
 
   This class can be a little bit more concise.
   
   The nullity check in `longMessage()` is made redundant by the lack of an equivalent check
in `shortMessage`. `CompilationFailureException` is thrown in two places in `AbstractCompilerMojo`
and both of those are guaranteed to pass a non-null object.
   
   Whilst we're in here, remove a redundant local variable in `shortMessage()` and merge the
`StringBuilder` calls onto a single line.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version
2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message