maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-compiler-plugin] rfscholte commented on a change in pull request #21: Cleanup debug log handling
Date Mon, 27 May 2019 17:30:37 GMT
rfscholte commented on a change in pull request #21: Cleanup debug log handling
URL: https://github.com/apache/maven-compiler-plugin/pull/21#discussion_r287852512
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
 ##########
 @@ -960,7 +963,7 @@ else if ( CompilerConfiguration.CompilerReuseStrategy.ReuseSame.getStrategy().eq
                 }
 
                 String[] cl = compiler.createCommandLine( compilerConfiguration );
-                if ( getLog().isDebugEnabled() && cl != null && cl.length
> 0 )
+                if ( cl != null && cl.length > 0 )
 
 Review comment:
   I would prefer to keep the `getLog().isDebugEnabled()` here, otherwise a lot a String concatenation
is done for showing the commandline, which is only shown during debug

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message