maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Scholte (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (MSHADE-316) Explicit minijar includes
Date Wed, 01 May 2019 19:10:00 GMT

     [ https://issues.apache.org/jira/browse/MSHADE-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Scholte closed MSHADE-316.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 3.2.2

Fixed in [2f6663c725d5b7fd42a177d530eb3577f370f323|https://gitbox.apache.org/repos/asf?p=maven-shade-plugin.git;a=commit;h=2f6663c725d5b7fd42a177d530eb3577f370f323]
Thanks for the patch!

> Explicit minijar includes
> -------------------------
>
>                 Key: MSHADE-316
>                 URL: https://issues.apache.org/jira/browse/MSHADE-316
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>            Reporter: Markus Karg
>            Assignee: Robert Scholte
>            Priority: Major
>             Fix For: 3.2.2
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Minijar currently respects includes, but these have a drawback: Once you defined an include,
the _default includes_ are gone! But what you actually want to have when combining minijar
with includes is just an "exception" to minijar's filtering, not a complete replacement of
the default includes!
> So what we need to make this work intuitively is either "explicit minijar exceptions",
or a "useDefaultIncludes=true" option that turns the notion from "replace default includes
by the single given include" to "add the single given include ontop of the default includes".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message