maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Heinz Marbaise (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)
Date Thu, 02 May 2019 17:13:00 GMT

     [ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Karl Heinz Marbaise updated MCOMPILER-381:
------------------------------------------
    Description: 
The code in the class AbstractCompilerMojo has a method {{isDependencyChanged}} which uses
the attribute {{fileExtensions}} which is being changed within the {{isDependencyChanged}}
method. This attribute is also being used by the method {{hasNewFile}} which is a kind of
confusing (a control via a global variable).
Furthermore a change in {{isDependencyChanged}} where replacing {{".class"}} with {{"class"}}
results in a [fail which is described here|MCOMPILER-379]. 

It should be investigated how this code can be made more clear and maybe easier to understand.



  was:Currently the code in Maven compiler plugin 


> Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)
> ----------------------------------------------------------------------------------------
>
>                 Key: MCOMPILER-381
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-381
>             Project: Maven Compiler Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.8.1
>            Reporter: Karl Heinz Marbaise
>            Priority: Minor
>             Fix For: 3.8.2
>
>
> The code in the class AbstractCompilerMojo has a method {{isDependencyChanged}} which
uses the attribute {{fileExtensions}} which is being changed within the {{isDependencyChanged}}
method. This attribute is also being used by the method {{hasNewFile}} which is a kind of
confusing (a control via a global variable).
> Furthermore a change in {{isDependencyChanged}} where replacing {{".class"}} with {{"class"}}
results in a [fail which is described here|MCOMPILER-379]. 
> It should be investigated how this code can be made more clear and maybe easier to understand.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message