maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roman Ivanov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MCHECKSTYLE-376) The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
Date Mon, 27 May 2019 16:41:00 GMT

    [ https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849074#comment-16849074
] 

Roman Ivanov commented on MCHECKSTYLE-376:
------------------------------------------

I would recommend to release maven plugin on checkstyle 8.20.
when users start to upgrade, they will have tons of new violations in code (few years of tons
of bugfixes in checkstyle).

it is better to not bother them with extensions recompilations, a lot of companies have their
own Checks(extensions), so it is better to not bother them with extra activity.

Please release plugin.

> The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
> ------------------------------------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-376
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-376
>             Project: Maven Checkstyle Plugin
>          Issue Type: Improvement
>          Components: checkstyle:check
>            Reporter: Tibor Digana
>            Assignee: Enrico Olivelli
>            Priority: Major
>         Attachments: linux.zip, windows.zip
>
>
> Afects version 3.1.0 during the release vote.
> It looks like the library expects system based EOL character.
> The checkstyle reports the issue in two files in https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
> I doubt it is a problem with these two files, nothing but the library itself.
> No idea why other ITs do not fail on Windows too.
> {noformat}
> mvn -nsu checkstyle:check
> [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @ mcheckstyle-54
---
> [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml ruleset.
> [ERROR] src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1]
(misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR] src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1]
(misc) NewlineAtEndOfFile: File does not end with a newline.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3.450 s
> [INFO] Finished at: 2019-05-13T23:42:55+02:00
> [INFO] Final Memory: 12M/193M
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check
(default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please read the
following articles:
> [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message