maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven] Tibor17 commented on issue #261: [MNG-6697] New fast model interpolator not using reflection
Date Tue, 02 Jul 2019 10:26:32 GMT
Tibor17 commented on issue #261: [MNG-6697] New fast model interpolator not using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507616968
 
 
   `FIELDS_CACHE` does not seem to have any usages, so it can be deleted.
   It's better to use `ConcurrentHashMap` instead of `HashMap` and then possibly use `computeIfAbsent`
instead of whole if-else. Not sure is the access to that Map is concurrent or not but it's
safety in the future and the implementation of the Map uses the locks only when necessary.
Additionally it gains the performance because the bucket is divided in to parts depending
on the number of CPU.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message