maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven] Tibor17 commented on a change in pull request #261: [MNG-6697] New fast model interpolator not using reflection
Date Tue, 02 Jul 2019 21:25:08 GMT
Tibor17 commented on a change in pull request #261: [MNG-6697] New fast model interpolator
not using reflection
URL: https://github.com/apache/maven/pull/261#discussion_r299691453
 
 

 ##########
 File path: maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java
 ##########
 @@ -71,32 +79,62 @@ public Model interpolateModel( Model model, File projectDir, ModelBuildingReques
     }
 
     protected void interpolateObject( Object obj, Model model, File projectDir, ModelBuildingRequest
config,
-                                      ModelProblemCollector problems )
+                                      final ModelProblemCollector problems )
     {
-        try
-        {
-            List<? extends ValueSource> valueSources = createValueSources( model, projectDir,
config, problems );
-            List<? extends InterpolationPostProcessor> postProcessors =
-                createPostProcessors( model, projectDir, config );
+        List<? extends ValueSource> valueSources = createValueSources( model, projectDir,
config, problems );
+        List<? extends InterpolationPostProcessor> postProcessors =
+            createPostProcessors( model, projectDir, config );
 
-            InterpolateObjectAction action =
-                new InterpolateObjectAction( obj, valueSources, postProcessors, this, problems
);
+        InnerInterpolator innerInterpolator = createInterpolator( valueSources, postProcessors,
problems );
+
+        PrivilegedAction<Object> action;
 
 Review comment:
   Use declaration and assignment at one line please.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message