maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven] Tibor17 commented on issue #261: [MNG-6697] New fast model interpolator not using reflection
Date Wed, 03 Jul 2019 08:00:22 GMT
Tibor17 commented on issue #261: [MNG-6697] New fast model interpolator not using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507985286
 
 
   I made an analysis the `cache` is used in the method stack of protected method, so it is
`stack confinement` threadsafety. So it's ok.
   
   yes, the domain objects in Maven should be best Immutable which avoids unnecessary cloning
and avoids problems with memory visibility between Threads, and then Maven should have services
with domain objects (not collections). The state of immutable objects would be valid at the
time when they were read from the services.
   yes, iterating through the whole hierarchy is pending issue. There should be singleton
(persistence layer) in memory keeping the domain objects with latest memory snapshot. Then
no recursive iteration would happen once the domain object was created.
   These two facts point to a bad status of the architecture in Maven.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message