maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven] michael-o commented on a change in pull request #264: [MNG-6535] Improve test coverage of UrlNormalizer.
Date Sat, 06 Jul 2019 15:09:45 GMT
michael-o commented on a change in pull request #264: [MNG-6535] Improve test coverage of UrlNormalizer.
URL: https://github.com/apache/maven/pull/264#discussion_r300834002
 
 

 ##########
 File path: maven-model-builder/src/test/java/org/apache/maven/model/path/DefaultUrlNormalizerTest.java
 ##########
 @@ -82,4 +82,8 @@ public void testPreservationOfDoubleSlashes()
                       normalize( "[fetch=]http://server.org/[push=]ssh://server.org/" ) );
     }
 
+    public void testNormalizeInputWithNoParentDirectoriesToAscendTo()
+    {
+        assertEquals("a/../", normalize("a/../"));
+    }
 
 Review comment:
   If we normalize URLs, the test for relative paths must fail. URLs are absolute.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message