maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-toolchains-plugin] hsynkrtl commented on issue #3: [MTOOLCHAINS-29] added optional <fail> parameter
Date Thu, 25 Jul 2019 19:30:48 GMT
hsynkrtl commented on issue #3: [MTOOLCHAINS-29] added optional <fail> parameter
URL: https://github.com/apache/maven-toolchains-plugin/pull/3#issuecomment-515182771
 
 
   The decision not to fix was a false decision in the first place.
   
   The changes of jdk9+ made the toolchain essencial again, But i am sure mostly, a warning
would be enough. At the first place the toolchains-plugin should provide the ability to share
configuration, not to enforce. This job does the enforcer plugin quite well with a great set
of built-in rules.
   
   I could imagine that it is maybe posible to switch jdk just by using profiles, even without
toolchain. But that would just blow up the POM. And it is the same with your consideration
to enable or disable toolchain by profiles.
   
   Just because there is a workaround, This feature shouldn't rejected.
   
   Despite of the last release, the toolchain plugin just didn't developed for a long time.
This would be a nice movement to get more similarity to enforcer plugin.
   
   This is an optional convenient and common (enforcer-plugin) feature. So come on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message