maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-gpg-plugin] rfscholte commented on a change in pull request #3: [MGPG-71] - Plugin does not work with GPG on OSX based on MacGPG2
Date Fri, 26 Jul 2019 12:55:36 GMT
rfscholte commented on a change in pull request #3: [MGPG-71] - Plugin does not work with GPG
on OSX based on MacGPG2
URL: https://github.com/apache/maven-gpg-plugin/pull/3#discussion_r307729443
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugin/gpg/GpgVersionParser.java
 ##########
 @@ -37,12 +37,11 @@
  */
 public class GpgVersionParser
 {
-    private final GpgVersionConsumer consumer;
+    private final GpgVersion gpgVersion;
 
-    private GpgVersionParser( GpgVersionConsumer consumer )
+    private GpgVersionParser( GpgVersion gpgVersion )
 
 Review comment:
   Conceptually this looks weird to me. A `GpgVersionParser` should get some kind of input
and the result would be a `GpgVersion`. Maybe the consumer as input is overkill, another solution
would be just a String.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message