maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven] eolivelli commented on a change in pull request #269: [MNG-6713] Fix ExclusionArtifactFilter to respect wildcard exclusions.
Date Sat, 27 Jul 2019 10:01:52 GMT
eolivelli commented on a change in pull request #269: [MNG-6713] Fix ExclusionArtifactFilter
to respect wildcard exclusions.
URL: https://github.com/apache/maven/pull/269#discussion_r307960403
 
 

 ##########
 File path: maven-core/src/main/java/org/apache/maven/artifact/resolver/filter/ExclusionArtifactFilter.java
 ##########
 @@ -41,8 +41,20 @@ public boolean include( Artifact artifact )
     {
         for ( Exclusion exclusion : exclusions )
         {
-            if ( exclusion.getGroupId().equals( artifact.getGroupId() )
-                    && exclusion.getArtifactId().equals( artifact.getArtifactId()
) )
+            if ( "*".equals( exclusion.getGroupId() ) && "*".equals( exclusion.getArtifactId()
) )
 
 Review comment:
   Can we have  global constant for '*' ?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message