maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-indexer] fuss86 commented on issue #26: ability to set index temp directory
Date Mon, 29 Jul 2019 20:29:22 GMT
fuss86 commented on issue #26: ability to set index temp directory
URL: https://github.com/apache/maven-indexer/pull/26#issuecomment-516149769
 
 
   > I wonder hiw we can add a minimal test that covers this change.
   > Maybe just running the indexer and setting the new field is enough.
   > Can you please add such test?
   
   added by @slachiewicz in https://github.com/apache/maven-indexer/commit/4a54f5f6fee979f8169d710c82247746ed69b9a4
   
   > One question: if the directory is not empty we can have unpredictable behavior.
   > Should we state this in a javadoc?
   
   It's used to store the index temporarily. It's name is `indexTempDir`. What kind of unpredictable
behavior user may expect here ?
   
   > We can't empty the directory automatically
   
   We are not emptying directory :) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message