maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MNG-6653) DefaultProjectBuildingRequest copy constructor does not copy all fields
Date Thu, 25 Jul 2019 20:15:00 GMT

     [ https://issues.apache.org/jira/browse/MNG-6653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Osipov updated MNG-6653:
--------------------------------
    Description: 
{code:java}
    public DefaultProjectBuildingRequest( ProjectBuildingRequest request )
    {
        this();
        setProcessPlugins( request.isProcessPlugins() );
        setProfiles( request.getProfiles() );
        setActiveProfileIds( request.getActiveProfileIds() );
        setInactiveProfileIds( request.getInactiveProfileIds() );
        setSystemProperties( request.getSystemProperties() );
        setUserProperties( request.getUserProperties() );
        setRemoteRepositories( request.getRemoteRepositories() );
        setPluginArtifactRepositories( request.getPluginArtifactRepositories() );
        setRepositorySession( request.getRepositorySession() );
        setLocalRepository( request.getLocalRepository() );
        setBuildStartTime( request.getBuildStartTime() );
        setProject( request.getProject() );
        setResolveDependencies( request.isResolveDependencies() );
        setValidationLevel( request.getValidationLevel() );
    }
{code}
This is missing {{setRepositoryMerging( request.getRepositoryMerging() );}} and {{setResolveVersionRanges(
request.isResolveVersionRanges() );}}.

  was:
{code:java}
    public DefaultProjectBuildingRequest( ProjectBuildingRequest request )
    {
        this();
        setProcessPlugins( request.isProcessPlugins() );
        setProfiles( request.getProfiles() );
        setActiveProfileIds( request.getActiveProfileIds() );
        setInactiveProfileIds( request.getInactiveProfileIds() );
        setSystemProperties( request.getSystemProperties() );
        setUserProperties( request.getUserProperties() );
        setRemoteRepositories( request.getRemoteRepositories() );
        setPluginArtifactRepositories( request.getPluginArtifactRepositories() );
        setRepositorySession( request.getRepositorySession() );
        setLocalRepository( request.getLocalRepository() );
        setBuildStartTime( request.getBuildStartTime() );
        setProject( request.getProject() );
        setResolveDependencies( request.isResolveDependencies() );
        setValidationLevel( request.getValidationLevel() );
    }
{code}
This is missing {{setRepositoryMerging( request.request.getRepositoryMerging() );}}.

PS: {{resolveVersionRanges}} is also "missing" but this is already deprecated/not used anymore.


> DefaultProjectBuildingRequest copy constructor does not copy all fields
> -----------------------------------------------------------------------
>
>                 Key: MNG-6653
>                 URL: https://issues.apache.org/jira/browse/MNG-6653
>             Project: Maven
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.6.1
>            Reporter: Falko Modler
>            Assignee: Sylwester Lachiewicz
>            Priority: Minor
>
> {code:java}
>     public DefaultProjectBuildingRequest( ProjectBuildingRequest request )
>     {
>         this();
>         setProcessPlugins( request.isProcessPlugins() );
>         setProfiles( request.getProfiles() );
>         setActiveProfileIds( request.getActiveProfileIds() );
>         setInactiveProfileIds( request.getInactiveProfileIds() );
>         setSystemProperties( request.getSystemProperties() );
>         setUserProperties( request.getUserProperties() );
>         setRemoteRepositories( request.getRemoteRepositories() );
>         setPluginArtifactRepositories( request.getPluginArtifactRepositories() );
>         setRepositorySession( request.getRepositorySession() );
>         setLocalRepository( request.getLocalRepository() );
>         setBuildStartTime( request.getBuildStartTime() );
>         setProject( request.getProject() );
>         setResolveDependencies( request.isResolveDependencies() );
>         setValidationLevel( request.getValidationLevel() );
>     }
> {code}
> This is missing {{setRepositoryMerging( request.getRepositoryMerging() );}} and {{setResolveVersionRanges(
request.isResolveVersionRanges() );}}.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message