maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Clark Perkins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1553) @Unroll forces usage of JUnit Vintage
Date Mon, 12 Aug 2019 02:41:00 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904805#comment-16904805
] 

Clark Perkins commented on SUREFIRE-1553:
-----------------------------------------

[~tibordigana]

I just pulled down maven-surefire master, and ran the sample maven-surefire-unroll repo against
it, with the following output:



[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.skrser.surefire.CalculatorTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 s - in com.skrser.surefire.CalculatorTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

 

 

$ ls target/surefire-reports/
TEST-com.skrser.surefire.CalculatorTest.xml 
com.skrser.surefire.CalculatorTest.txt

 

All the tests for CalculatorSpockTest seem to have been counted towards CalculatorTest, which
is still not desired.

 

I'm using maven 3.6.1 on macOS with java 1.8.0_202 if that helps.

The commit hash I built on maven-surefire was a2a5d120c0bf0fe2f82408d5979abad8a360175c

> @Unroll forces usage of JUnit Vintage
> -------------------------------------
>
>                 Key: SUREFIRE-1553
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1553
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: JUnit 5.x support, Maven Surefire Plugin
>    Affects Versions: 2.22.0
>            Reporter: Sergey Skryabin
>            Assignee: Tibor Digana
>            Priority: Major
>
> If run
> {code}mvn clean test{code}
> JUnit4 tests and Spock tests (which not contain @Unroll) are executed normally. Once
Spock test with @Unroll annotation appears, then Surefire execute
> {code}[INFO] Running JUnit Vintage{code}
>  and all other JUnit4 tests and Spock tests are wrapped with this runner. 
> In surefire-reports I see _TEST-<all tests executed before meeting @Unroll>.xml_
s and than
> _TEST-JUnit Vintage.xml_
> Though it could be done by intention, behaviour is different from 2.21.0 (no wrapping
with Vintage). Also it much more visible to have separate reports per test class (both in
console output and surefire-reports folder).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message