maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hüseyin Kartal (JIRA) <j...@apache.org>
Subject [jira] [Updated] (MNG-6728) toolchain.xml should support absense of version and/or vendor in the configuraion
Date Tue, 06 Aug 2019 11:12:00 GMT

     [ https://issues.apache.org/jira/browse/MNG-6728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hüseyin Kartal updated MNG-6728:
--------------------------------
    Description: 
When a toolchain.xml is configured as follow:
{noformat}
<?xml version="1.0" encoding="UTF8"?>
<toolchains>
  <!-- JDK toolchains -->
  <toolchain>
    <type>jdk</type>
    <provides>
      <version>8</version>
      <vendor>oracle</vendor>
    </provides>
    <configuration>
      <jdkHome>${env.JDK_HOME_8}</jdkHome>
    </configuration>
  </toolchain>
  <toolchain>
    <type>jdk</type>
    <provides>
      <version>12</version>
      <vendor>oracle</vendor>
    </provides>
    <configuration>
      <jdkHome>${env.JDK_HOME_12}</jdkHome>
    </configuration>
  </toolchain>
  <toolchain>
    <type>jdk</type>
    <configuration>
      <jdkHome>${env.JAVA_HOME}</jdkHome>
    </configuration>
  </toolchain>
 </toolchains>
{noformat}
The last jdk configuration without version and vendor should match any requested version and/or
vendor.

This would allow us to define a fallback toolchain.

The idea behind this improvement is that we don't want the toolchain plugin to enforce a jdk, this
we would do with the enforcer plugin. We want to use the toolchain plugin just for supply
the best JDK. We also want reduce the maintainance of the toolchain.xml on our different
development and cicd systems.

  was:
When a toolchain.xml is configured as follow:

{noformat}
<?xml version="1.0" encoding="UTF8"?>
<toolchains>
  <!-- JDK toolchains -->
  <toolchain>
    <type>jdk</type>
    <provides>
      <version>8</version>
      <vendor>oracle</vendor>
    </provides>
    <configuration>
      <jdkHome>${env.JDK_HOME_8}</jdkHome>
    </configuration>
  </toolchain>
  <toolchain>
    <type>jdk</type>
    <provides>
      <version>12</version>
      <vendor>oracle</vendor>
    </provides>
    <configuration>
      <jdkHome>${env.JDK_HOME_12}</jdkHome>
    </configuration>
  </toolchain>
  <toolchain>
    <type>jdk</type>
    <configuration>
      <jdkHome>${env.JAVA_HOME}</jdkHome>
    </configuration>
  </toolchain>
 </toolchains>
{noformat}

The last jdk configuration without version and vendor should match any requested version and/or
vendor.

This would allow us to define a fallback toolchain.


> toolchain.xml should support absense of version and/or vendor in the configuraion
> ---------------------------------------------------------------------------------
>
>                 Key: MNG-6728
>                 URL: https://issues.apache.org/jira/browse/MNG-6728
>             Project: Maven
>          Issue Type: Improvement
>          Components: Toolchains
>    Affects Versions: 3.6.1
>            Reporter: Hüseyin Kartal
>            Priority: Minor
>              Labels: usability
>
> When a toolchain.xml is configured as follow:
> {noformat}
> <?xml version="1.0" encoding="UTF8"?>
> <toolchains>
>   <!-- JDK toolchains -->
>   <toolchain>
>     <type>jdk</type>
>     <provides>
>       <version>8</version>
>       <vendor>oracle</vendor>
>     </provides>
>     <configuration>
>       <jdkHome>${env.JDK_HOME_8}</jdkHome>
>     </configuration>
>   </toolchain>
>   <toolchain>
>     <type>jdk</type>
>     <provides>
>       <version>12</version>
>       <vendor>oracle</vendor>
>     </provides>
>     <configuration>
>       <jdkHome>${env.JDK_HOME_12}</jdkHome>
>     </configuration>
>   </toolchain>
>   <toolchain>
>     <type>jdk</type>
>     <configuration>
>       <jdkHome>${env.JAVA_HOME}</jdkHome>
>     </configuration>
>   </toolchain>
>  </toolchains>
> {noformat}
> The last jdk configuration without version and vendor should match any requested version
and/or vendor.
> This would allow us to define a fallback toolchain.
> The idea behind this improvement is that we don't want the toolchain plugin to enforce
a jdk, this we would do with the enforcer plugin. We want to use the toolchain plugin just
for supply the best JDK. We also want reduce the maintainance of the toolchain.xml on our
different development and cicd systems.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message