maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-surefire] Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5
Date Fri, 01 Nov 2019 20:40:36 GMT
Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for
JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-548942695
 
 
   @Col-E 
   It is fix for this PR. It is new code. It was not before, right?
   So we have to report issue and make new PR the same way as we did it before.
   
   And then the next issue would go with ParmeterizedTest only and not rerun saying that the
Parameterize test should have different name for every combination of parameters. If we use
`getLegacyReportingName()` instead of pure method name in the String[2] then integration test
will pass. I mean this test from @Seijan was not IT. It was unit test but we need to have
real IT and we have to check the XML report as well as the number of calls of the same method
and we do not have to employ the rerun because it was fixed previously by you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message