maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-shade-plugin] peterdemaeyer opened a new pull request #30: [MSHADE-284] - Shaded test JARs are always empty
Date Fri, 01 Nov 2019 21:24:54 GMT
peterdemaeyer opened a new pull request #30: [MSHADE-284] - Shaded test JARs are always empty
URL: https://github.com/apache/maven-shade-plugin/pull/30
 
 
   This PR fixes [MSHADE-284](https://issues.apache.org/jira/browse/MSHADE-284).
   - IT added (all the new files in this PR are for the IT).
   - Test fails before fix, succeeds after.
   - "mvn clean verify" succeeds.
   - "mvn -Prun-its clean verify" succeeds.
    - [x] I hereby declare this contribution to be licensed under the [Apache License Version
2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
   [After all these years, once this PR gets merged, shadeTestJar will _finally_ work like
it was supposed to, and people can stop using the assembly plugin as a workaround.](https://stackoverflow.com/questions/5149130/how-can-i-configure-the-maven-shade-plugin-to-include-test-code-in-my-jar)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message