maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-surefire] Col-E edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5
Date Fri, 01 Nov 2019 21:24:56 GMT
Col-E edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for
JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-548949938
 
 
   >It is fix for this PR. It is new code. It was not before, right?
   
   Yes it is a fix for this PR. I would not call this _"new code"_ though if we are talking
in terms of code coverage.
   
   ![image](https://user-images.githubusercontent.com/21371686/68056256-0be9ab80-fcc9-11e9-9b0b-688434818f9a.png)
   
   > So we have to report issue and make new PR the same way as we did it before.
   
   I agree.
   
   > If we use `getLegacyReportingName()` instead of pure method name in the String[2]
then integration test will pass
   
   I do not understand why the legacy name should be used over `UniqueId` as suggested by
https://github.com/apache/maven-surefire/pull/245#issuecomment-548777170
   
   We can even roll back the changes to `RunListenerAdapter`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message