maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-resolver] rfscholte commented on a change in pull request #52: [MRESOLVER-56] Support SHA-256 and SHA-512 as checksums
Date Mon, 01 Jun 2020 07:51:19 GMT

rfscholte commented on a change in pull request #52:
URL: https://github.com/apache/maven-resolver/pull/52#discussion_r433091079



##########
File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SimpleDigest.java
##########
@@ -37,18 +37,32 @@
     {
         try
         {
-            digest = MessageDigest.getInstance( "SHA-1" );
+            digest = MessageDigest.getInstance( "SHA-512" );

Review comment:
       I spotted the same codesmell: nested try-catch blocks. Should be able to rewrite that.
with a single try-catch level
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message