maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven] pzygielo commented on a change in pull request #355: Add a Jenkinsfile to run it test (per default it runs it master branch but there is a parameter to use a different it source branch)
Date Mon, 01 Jun 2020 11:40:04 GMT

pzygielo commented on a change in pull request #355:
URL: https://github.com/apache/maven/pull/355#discussion_r433185876



##########
File path: pom.xml
##########
@@ -552,6 +552,7 @@ under the License.
               -->
               <exclude>src/main/appended-resources/licenses/CDDL-1.0.txt</exclude>
               <exclude>src/main/appended-resources/licenses/EPL-1.0.txt</exclude>
+              <excludes>Jenkinsfile.its</excludes>

Review comment:
       Why not add proper license to new Jenkinsfile and drop this exclusion?
   BTW comment in line 551 suggests it is license file, doesn't it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message