maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven] 2997ms commented on a change in pull request #360: [MNG-6891] Delete the useless codes which won't be executed
Date Tue, 02 Jun 2020 16:23:59 GMT

2997ms commented on a change in pull request #360:
URL: https://github.com/apache/maven/pull/360#discussion_r434009485



##########
File path: maven-slf4j-wrapper/src/main/java/org/apache/maven/logwrapper/LogLevelRecorder.java
##########
@@ -42,14 +42,7 @@
 
     public LogLevelRecorder( String threshold )
     {
-        Level level = determineThresholdLevel( threshold );
-
-        if ( level.toInt() < Level.WARN.toInt() )
-        {
-            throw new IllegalArgumentException( "Logging severity thresholds can only be
set to WARN or ERROR" );
-        }
-
-        logThreshold = level;
+        logThreshold = determineThresholdLevel( threshold );

Review comment:
       We only accept these two levels logging https://github.com/apache/maven/pull/337/files#diff-1539b34a819f425067138253cfac27adR35
   And the logging level value is `   ERROR(40, "ERROR"),
       WARN(30, "WARN"),
       INFO(20, "INFO"),
       DEBUG(10, "DEBUG"),
       TRACE(0, "TRACE");`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message