maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-ear-plugin] elharo commented on a change in pull request #10: [MEAR-283] Reproducible builds with skinnyWar option
Date Tue, 01 Sep 2020 13:18:30 GMT

elharo commented on a change in pull request #10:
URL: https://github.com/apache/maven-ear-plugin/pull/10#discussion_r481130048



##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -285,6 +286,11 @@ public void execute()
         super.execute();
 
         zipArchiver.setUseJvmChmod( useJvmChmod );
+        final Date parsedOutputTimestamp = new MavenArchiver().parseOutputTimestamp( outputTimestamp
);

Review comment:
       the parseOutputTimestamp method should really be static. I wonder if we can change
that now?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message