maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-ear-plugin] pzygielo commented on a change in pull request #10: [MEAR-283] Reproducible builds with skinnyWar option
Date Tue, 01 Sep 2020 15:56:06 GMT

pzygielo commented on a change in pull request #10:
URL: https://github.com/apache/maven-ear-plugin/pull/10#discussion_r481249976



##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -285,6 +286,11 @@ public void execute()
         super.execute();
 
         zipArchiver.setUseJvmChmod( useJvmChmod );
+        final Date parsedOutputTimestamp = new MavenArchiver().parseOutputTimestamp( outputTimestamp
);

Review comment:
       >  I don't think changing a method from instance to static is a major breaking change.
   
   But it is breaking change. Compare: [13.4.12. Method and Constructor Declarations](https://docs.oracle.com/javase/specs/jls/se14/html/jls-13.html#jls-13.4.12).
Such change results in `IncompatibleClassChangeError`: _Expecting non-static method..._.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message