maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-ear-plugin] hboutemy commented on a change in pull request #10: [MEAR-283] Reproducible builds with skinnyWars option
Date Sat, 05 Sep 2020 23:15:03 GMT

hboutemy commented on a change in pull request #10:
URL: https://github.com/apache/maven-ear-plugin/pull/10#discussion_r483998880



##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -285,6 +286,11 @@ public void execute()
         super.execute();
 
         zipArchiver.setUseJvmChmod( useJvmChmod );
+        final Date parsedOutputTimestamp = new MavenArchiver().parseOutputTimestamp( outputTimestamp
);

Review comment:
       in fact, instead of creating a temporary MavenArchiver here, the instance created later
should be moved up and the Date should be read from "archiver.configureReproducible( outputTimestamp
)"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message