maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #10: [MEAR-283] Reproducible builds with skinnyWars option
Date Mon, 07 Sep 2020 05:25:17 GMT

mabrarov commented on a change in pull request #10:
URL: https://github.com/apache/maven-ear-plugin/pull/10#discussion_r484188208



##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -285,6 +286,11 @@ public void execute()
         super.execute();
 
         zipArchiver.setUseJvmChmod( useJvmChmod );
+        final Date parsedOutputTimestamp = new MavenArchiver().parseOutputTimestamp( outputTimestamp
);

Review comment:
       @hboutemy, 
   
   I've implemented your suggestion (reworked this PR) in 28c0fd1 to use value returned by
`archiver.configureReproducible( outputTimestamp )`.
   
   Thank you for noticing that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message