maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #10: [MEAR-283] Reproducible builds with skinnyWars option
Date Mon, 07 Sep 2020 19:17:45 GMT

mabrarov commented on a change in pull request #10:
URL: https://github.com/apache/maven-ear-plugin/pull/10#discussion_r484549347



##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -284,7 +285,33 @@ public void execute()
         // Initializes ear modules
         super.execute();
 
+        final File earFile;

Review comment:
       I'm afraid that if we expand try block then we will change the way exceptions are handled.
So the answer is "no, we cannot" if we don't want to dive into details on how existing code
handles exceptions :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message