maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe Cloutier (Jira)" <j...@apache.org>
Subject [jira] [Commented] (MNG-6093) create a slf4j-simple provider extension that supports level color rendering
Date Fri, 25 Sep 2020 21:06:00 GMT

    [ https://issues.apache.org/jira/browse/MNG-6093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202427#comment-17202427
] 

Philippe Cloutier commented on MNG-6093:
----------------------------------------

Would someone explain how this was solved? The links are broken so I really can't figure it
out.

> create a slf4j-simple provider extension that supports level color rendering
> ----------------------------------------------------------------------------
>
>                 Key: MNG-6093
>                 URL: https://issues.apache.org/jira/browse/MNG-6093
>             Project: Maven
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Herve Boutemy
>            Assignee: Herve Boutemy
>            Priority: Major
>             Fix For: 3.5.0-alpha-1, 3.5.0
>
>
> With color support, core Maven and plugins do general message colorization (or more high-level
"message styling" through maven-shared-utils)
> slf4j provider however has to add color:
> - for log level output (DEBUG/INFO/WARNING/ERROR)
> - for stacktrace rendering
> That's why we use Gossip slf4j provider: it has sufficient little extension points to
add this, with just a little bit of code (see http://maven.apache.org/ref/3-LATEST/maven-embedder/apidocs/org/apache/maven/cli/logging/impl/gossip/package-summary.html
) and configuration
> The issue with switching to Gossip slf4j provider is that people don't know it and it
does not have the same features as slf4j-simple (missing relative timestamps and configuration
with CLI: see http://mail-archives.apache.org/mod_mbox/maven-dev/201607.mbox/%3CCAK8jvqxYNK4weM2Frp4Brg3J7EybyjBiCsSRdGuNMQhYAG728Q%40mail.gmail.com%3E
), the configuration file is not the same (name nor content).
> But the extension points are not that big: if slf4j-simple provider just made a few methods
protected instread of private, it would be extensible
> What if we just copy slf4j-simple to change the signatures and create small extension
classes? The license permits it, we can try it and eventually see with slf4j if the modification
can go into official release



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message